Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logs -f hanging on stopped containers #7629

Merged
merged 2 commits into from Aug 25, 2014
Merged

Fix logs -f hanging on stopped containers #7629

merged 2 commits into from Aug 25, 2014

Conversation

LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Aug 19, 2014

Fixes #7020

@LK4D4
Fix logs -f hanging on stopped containers
badf824 
Fixes #7020

Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com>
@LK4D4
Copy link
Contributor Author

LK4D4 commented Aug 20, 2014

@vieux Test added

@LK4D4
Test for following logs for stopped container
f04ef96 
Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com>
@vieux
Copy link
Contributor

vieux commented Aug 22, 2014

LGTM

@vieux vieux added this to the 1.3.0 milestone Aug 22, 2014
@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Aug 25, 2014
@crosbymichael
Merge pull request #7629 from LK4D4/fix_follow_hang_on_stop
228eda4 
Fix logs -f hanging on stopped containers
@crosbymichael crosbymichael merged commit 228eda4 into moby:master Aug 25, 2014
@LK4D4 LK4D4 deleted the fix_follow_hang_on_stop branch August 26, 2014 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

logs -f blocks forever when container is stopped
3 participants
@LK4D4 @vieux @crosbymichael