add support to set MemorySwap #9603
Conversation
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
|
Why wouldn't you send this with |
|
It's implementing the exact same function as |
|
never mind my bad, missed the one important line |
| @@ -136,6 +137,15 @@ func Parse(cmd *flag.FlagSet, args []string) (*Config, *HostConfig, *flag.FlagSe | |||
| flMemory = parsedMemory | |||
| } | |||
|
|
|||
| var MemorySwap int64 | |||
There was a problem hiding this comment.
this should be flMemorySwap
There was a problem hiding this comment.
Yeah, I considered this before, we already used flMemorySwap above, normally
this should be flMemorySwapString, but it's a bit too long.
If it's OK, I can change it to flMemorySwapString, what do you think?
There was a problem hiding this comment.
don't worry about it, just keep it as is
|
LGTM |
|
This still has a dep on libcontainer being updated in docker. I'm working on that right now and will merge after we have the libcontainer change merged in. |
|
LGTM |
|
I think this was the commit @crosbymichael was referring to: docker-archive/libcontainer@e8f5b54 and it was merged |
Signed-off-by: Qiang Huang h.huangqiang@huawei.com