Add windows back. #9642
Add windows back. #9642
Conversation
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
|
LGTM |
|
Let's fix the issues that caused us to remove this in time for 1.5, yeah? 😉 👍 |
|
ya! On Fri, Dec 12, 2014 at 2:29 PM, Tianon Gravi notifications@github.com
|
|
LGTM. We've new folks to work on this on board now and I'll be on vacation for almost a month. I hope we can make it to 1.5! 😉 |
|
Have a great vacation!! On Saturday, December 13, 2014, Ahmet Alp Balkan notifications@github.com
|
|
yay! |
| @@ -68,9 +68,8 @@ RUN cd /usr/local/go/src && ./make.bash --no-clean 2>&1 | |||
| ENV DOCKER_CROSSPLATFORMS \ | |||
| linux/386 linux/arm \ | |||
| darwin/amd64 darwin/386 \ | |||
| freebsd/amd64 freebsd/386 freebsd/arm | |||
| # windows is experimental for now | |||
There was a problem hiding this comment.
isn't windows still experimental? :)
There was a problem hiding this comment.
yes but this way people can build from the Dockerfile and we can generate
the binaries for master.dockerproject.com
On Mon, Dec 15, 2014 at 8:32 AM, Alexander Morozov <notifications@github.com
wrote:
In Dockerfile
#9642 (diff):@@ -68,9 +68,8 @@ RUN cd /usr/local/go/src && ./make.bash --no-clean 2>&1
ENV DOCKER_CROSSPLATFORMS
linux/386 linux/arm
darwin/amd64 darwin/386 \
- freebsd/amd64 freebsd/386 freebsd/arm
-# windows is experimental for nowisn't windows still experimental? :)
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/9642/files#r21836991.
There was a problem hiding this comment.
I only removed it for the release script
On Mon, Dec 15, 2014 at 8:34 AM, Jessica Frazelle jess@docker.com wrote:
yes but this way people can build from the Dockerfile and we can generate
the binaries for master.dockerproject.comOn Mon, Dec 15, 2014 at 8:32 AM, Alexander Morozov <
notifications@github.com> wrote:In Dockerfile
#9642 (diff):@@ -68,9 +68,8 @@ RUN cd /usr/local/go/src && ./make.bash --no-clean 2>&1
ENV DOCKER_CROSSPLATFORMS
linux/386 linux/arm
darwin/amd64 darwin/386 \
- freebsd/amd64 freebsd/386 freebsd/arm
-# windows is experimental for nowisn't windows still experimental? :)
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/9642/files#r21836991.
|
LGTM |
Post Major Release: Now it can be part of the master builds again :)
ping @tianon @ahmetalpbalkan