Add docker-py integration tests aginst the docker daemon #9741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clones and run the integration tests for docker-py master as part of the integration tests created on master. docker-py hits the api directly and should be a good way to identify regressions in the api. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
See, another case where having Drone run |
|
I also propose we wait to really consider this until tomorrow when 0.7.0 is expected to drop so we can switch over to using that tag instead of this temporary 0.6.0-integration branch that @shin- is nice enough to have up for us with some fixes that've happened to that test since 0.6.0 was tagged. 👍 |
- move docker/docker-py clone to the Dockerfile - put "integration test daemon startup" code in a separate file for both scripts to source - add new test-docker-py Makefile target - include "python-websocket" package in Dockerfile for running the tests Signed-off-by: Andrew "Tianon" Page <admwiggin@gmail.com>
tianon
force-pushed
the
test-docker-py
branch
from
d1a8c30
to
100267d
Compare
|
Updated with 0.7.0! 👍 |
|
wooohoooo |
|
Haha, panic on drone! |
|
👍 |
|
LGTM |
|
I create the new drone images as soon as this is merged |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Dec 19, 2014
Add docker-py integration tests aginst the docker daemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9676
Changes from @crosbymichael's code: