Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libcontainer to 1597c68f7b941fd97881155d7f077852e2914e7b #9795

Merged
merged 1 commit into from
Dec 23, 2014
Merged

Update libcontainer to 1597c68f7b941fd97881155d7f077852e2914e7b #9795

merged 1 commit into from
Dec 23, 2014

Conversation

LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Dec 23, 2014

@LK4D4
Update libcontainer to 1597c68f7b941fd97881155d7f077852e2914e7b
50905a6 
This commit contains changes for docker:
* user.GetGroupFile to user.GetGroupPath docker-archive/libcontainer#301
* Add systemd support for OOM docker-archive/libcontainer#307
* Support for custom namespaces docker-archive/libcontainer#279, docker-archive/libcontainer#312
* Fixes #9699 docker-archive/libcontainer#308

Signed-off-by: Alexander Morozov <lk4d4@docker.com>
@tianon
Copy link
Member

tianon commented Dec 23, 2014

LGTM

@tianon
Copy link
Member

tianon commented Dec 23, 2014

Drone is sad...

@jessfraz
Copy link
Contributor

I restarted, idk something in integration, all of integration-cli passed

On Tue, Dec 23, 2014 at 12:34 PM, Tianon Gravi notifications@github.com
wrote:

Drone is sad...

—
Reply to this email directly or view it on GitHub
#9795 (comment).

@LK4D4
Copy link
Contributor Author

LK4D4 commented Dec 23, 2014

Hah, passed

@jessfraz
Copy link
Contributor

yayyyy LGTM

@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Dec 23, 2014
@crosbymichael
Merge pull request #9795 from LK4D4/update_libcontainer
305c898 
Update libcontainer to 1597c68f7b941fd97881155d7f077852e2914e7b
@crosbymichael crosbymichael merged commit 305c898 into moby:master Dec 23, 2014
This was referenced Dec 27, 2014
Closed
Closed
@unclejack
Copy link
Contributor

Do we need this for 1.4.2?

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jan 5, 2015

@unclejack I don't know, this fixing bad bug with exec, but exec is not critical part of docker.

@ggrandes
Copy link

ggrandes commented Jan 5, 2015

+1 for 1.4.2 :-)

@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
@fcamblor
Copy link

Is there any workaround to be able to stop the running instance ? (specifying a timeout to docker stop doesn't help)

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jan 27, 2015

@fcamblor You need to find cgroups for this container and remove them.
I think something like:

find /sys/fs/cgroup *<container-id>

should help find them, but I don't tried.

@fcamblor
Copy link

Thanks, in fact, I were using boot2docker (mac install) and stopping/restarting boot2docker removed the running instance.

@chenhanxiao chenhanxiao mentioned this pull request Feb 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot stop container XXX: no such process w/ 1.4.0
7 participants
@LK4D4 @tianon @jessfraz @crosbymichael @unclejack @ggrandes @fcamblor