Remove BridgeIP from ipallocation pool #9975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes moby#9938 Signed-off-by: Malte Janduda <mail@janduda.net>
|
ping @LK4D4 |
|
This also closes #9949 |
|
@LK4D4 OK |
|
@jfrazelle #9771 seems like UX. So this will be fine. |
jessfraz
pushed a commit
that referenced
this pull request
Jan 8, 2015
Remove BridgeIP from ipallocation pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9938
The Bridge IP will be allocated during Docker network driver initialization.
Apart from that I have removed to update the next/last pointer in the ipallocation logic when a specific IP address is requested.
Currently when you request a specific IP address manually for container A, a container B that will be created afterwards will get the IP address of container A + 1.
With my changes in
daemon/networkdriver/ipallocator/allocator.gocontainer B will get the last automatically assigned IP address + 1.