Refactor Dockerfile version number usage #9995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I 😻 this one - it means I can look at the env to find out what version was installed - chances are, those few times i care, i'm already running that image interactively. (i prefer to keep the |
|
I'm okay with this, if sven likes |
This refactors version number usage for several of our "download/install this exact version" bits so we have an easier time replacing the version numbers in Jenkins. Signed-off-by: Andrew "Tianon" Page <admwiggin@gmail.com>
|
Updated! |
|
LGTM now I can build w different goversions easily in jenkins :D |
|
Most annoying thing that such PRs can't be tested with drone. |
|
once we get jenkins all good for all the graphdrivers/execdrivers (re the issues I opened for overlay and lxc and the btrfs dind issues) we will use that for PRs and it WILL build the dockerfile |
|
@jfrazelle Awesome. |
LK4D4
added a commit
that referenced
this pull request
Jan 9, 2015
Refactor Dockerfile version number usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors version number usage for several of our "download/install this exact version" bits so we have an easier time replacing the version numbers in Jenkins.
See also #9993 (which this is based on / includes).