manager: Fix start/stop race #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m.connSelector is set in Run while the manager is starting up. If Stop is called before this point, m.connSelector might be created after there is any possibility of stopping it, which would result in a goroutine leak. Make Stop wait for the connSelector to be created, to avoid this situation. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Current coverage is 54.88% (diff: 100%)@@ master #1263 diff @@
==========================================
Files 78 78
Lines 12422 12422
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6799 6818 +19
+ Misses 4679 4664 -15
+ Partials 944 940 -4
|
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m.connSelector is set in Run while the manager is starting up. If Stop
is called before this point, m.connSelector might be created after there
is any possibility of stopping it, which would result in a goroutine
leak.
Make Stop wait for the connSelector to be created, to avoid this
situation.
cc @LK4D4