Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager: Fix start/stop race #1263

Merged
merged 1 commit into from
Jul 28, 2016
Merged

manager: Fix start/stop race #1263

merged 1 commit into from
Jul 28, 2016

Commits on Jul 28, 2016

  1. manager: Fix start/stop race 

    m.connSelector is set in Run while the manager is starting up. If Stop
is called before this point, m.connSelector might be created after there
is any possibility of stopping it, which would result in a goroutine
leak.

Make Stop wait for the connSelector to be created, to avoid this
situation.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
    @aaronlehmann
    aaronlehmann committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    4086f0a View commit details
    Browse the repository at this point in the history