Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Allow to specify multiple layers for services #89

Closed
samoht opened this issue Jun 21, 2017 · 3 comments
Closed

Allow to specify multiple layers for services #89

samoht opened this issue Jun 21, 2017 · 3 comments

Comments

@samoht
Copy link
Member

samoht commented Jun 21, 2017

Currently we can specify multiple layers for the init image, but not for onboot or services images. Would be great to allow this as well.

@rn
Copy link
Member

rn commented Jun 21, 2017 via email

@MagnusS
Copy link
Contributor

MagnusS commented Jun 21, 2017

My use case is adding binaries to an existing service without having to rebuild/modify the whole image. For Docker for Mac we need transfused to talk to osxfs, vpnkit-expose-port as a userland proxy and an iptables binary to workaround a swarm issue inside docker-ce. We added vpnkit-expose-port to the docker-ce image directly, but the other binaries are DfM specific and osxfs is not open source yet so this doesn't seem like a possible option.

Currently I think the only alternative way to do this is to use init-containers to put the binaries in a temporary location and then bind mount them into the target service - or bind mount them from a different service using the path (which is not really supported and will break soon).

@justincormack
Copy link
Collaborator

There is basically no way we can do this once we switch over to image store, as you just get to unpack one image, and then add bind mounts. As Docker build has perfectly good ways of adding layers to images I would use that, and simply extend the existing base images, although the bind mount thing is also possible.

We do want to make a build tool (to replace the package Makefiles) and this could be a feature for that in future, but its not really possible now, so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants