-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix memory leak when run in v8; closes #3119
- this means "multiple calls to done" will once again fail to produce a stack trace in the case that those multiple calls happen in separate tasks. - however, if the `done()` is called with an error, Mocha will emit that error, but also a note about multiple calls - some reformatting, evidently - removed some pointless checks of Mocha's exit code from "multiple done" integration tests Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
- Loading branch information
Showing
4 changed files
with
48 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
test/integration/fixtures/multiple-done-with-error.fixture.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
'use strict'; | ||
|
||
it('should fail in a test-case', function (done) { | ||
process.nextTick(function () { | ||
done(); | ||
done(new Error('second error')); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters