Make sibling Suites have separate contexts

[park9140]

The main context in mocha is currently shared by all suites.

This change makes it so that each suite can add values to it's own context without polluting the shared global context.

This allows a layer of automatic cleanup to occur between test suites. Making after mostly unnecessary if you are using the shared context to store setup rather than using the closure.

[park9140]

@travisjeffery or @visionmedia any thoughts on this?

[park9140]

@travisjeffery or @visionmedia still looking for input.

[travisjeffery]

seems like a good idea, I'll take a closer look later today

On Tuesday, April 15, 2014, Jonathan Park notifications@github.com wrote:

@travisjeffery https://github.com/travisjeffery or @visionmediahttps://github.com/visionmediastill looking for input.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1164#issuecomment-40486992
.

[benvinegar]

+1

[park9140]

@travisjeffery, Thanks for looking at this, if you have any changes you would like, I can surely get some time today to resolve them.

[park9140]

@travisjeffery I just realized that I should just leave all the original tests in place rather than trying to intermix the sibling tests. Should I break the sibling tests into a separate file as well?

[travisjeffery]

@park9140 no keep them in one context file

[park9140]

@travisjeffery, cool, I'll leave it as is then.

[travisjeffery]

@park9140 ok and can you squash these commits into a single commit and force push your branch

[park9140]

@travisjeffery, done

[travisjeffery]

awesome thanks

[moll]

Why not use Object.create instead of the prototype+new thing you did in the code?

[onetom]

Since there is no cross talk between it steps, is it recommended to use the test context instead of closure variables to share state?

describe 'Something', ->
    user = null
    before -> user = Factory.build 'User'
    it '', -> expect( user.name ).to.be.not.empty

vs

describe 'Something', ->
    before -> @user = Factory.build 'User'
    it '', -> expect( @user.name ).to.be.not.empty

[onetom]

To me this seem to allow to use mocha finally, properly as an integration test framework too, not just as a unit test one, is that correct?

With mocha --ui exports I can write something like:

'Feature: Scratch my head':
    before -> @head = new Head
    'Scenario: From the left':
        'Given my head itches': -> @head.itch = true
        'When I scratch it': -> ...
    'Scenario: From the right':

[travisjeffery]

@onetom #1164 (comment) - either's fine. #1164 (comment) - probably could of used mocha before, but sure.