Silence Bluebird js warnings #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krisr This fails a lint check; please fix, otherwise LGTM. |
krisr
force-pushed
the
kris-silence-warnings
branch
from
9d2fba9
to
4af3866
Compare
|
@boneskull, thanks. I fixed the whitespace issue. |
boneskull
added a commit
that referenced
this pull request
Nov 18, 2015
Silence Bluebird js warnings
|
tyvm! |
|
Any chance of publishing a new release? Just ran into this myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluebird js now prints a warning message and stack trace when it discovers Promises that create other Promises but do not return them. Mocha trips this warning when the user chains together multiple hooks, and this PR eliminates the warning by explicitly returning null instead of undefined which signals that the warning should not be emitted.