Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stages and build matrices #3308

Merged
merged 8 commits into from
Apr 4, 2018
Merged

update stages and build matrices #3308

merged 8 commits into from
Apr 4, 2018

Conversation

boneskull
Copy link
Contributor

  • fiddle with caching
    • don't cache for smoke tests
    • npm@5 comes with node@8 or newer, so cache ~/.npm as well
    • otherwise, don't.
  • smoke test for each node.js version (stage 1)
  • lint (stage 2)
  • tests for each node.js version and browsers (stage 3)
  • addons (artifacts, sauce labs, chrome) are only present for browser tests!

YAML aliases are basically voodoo.

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 4, 2018
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.955% when pulling 1383060 on experimental/travis into f2560e7 on master.

@outsideris
Copy link
Contributor

It looks good!

There is one thing.

2018-04-05 00 39 25

It's hard to distinguish test.node and test.browser with node 9. Setting environment varibles can address this.
What do you think?

@boneskull
Copy link
Contributor Author

I raised this issue with Travis CI. If I set an environment variable then the cache can not be reused between the node and browser tests. There’s unfortunately no other way to distinguish them except to add a new stage at this point. Or just don’t worry about the caching

Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it. I hope that TravisCI addresses the problem.

sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
* optimize build stages and jobs
* attempt to avoid $TARGET
* run smoke tests across multiple node versions
* define addons per-job
* disable caching for smoke tests; avoid alias
* disable caching for older node versions entirely
* combine bundle / browser tests; do not run extra node 9 job

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants