Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Parts of #3783 #3784

Closed
wants to merge 3 commits into from
Closed

Fixes Parts of #3783 #3784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e93239
removed shortcut from favicon, added external tag to hrefs and tweake…
CDNRae Feb 28, 2019
4999b43
made fixes outlined in PR review
CDNRae Mar 1, 2019
92ba015
changed footer span to footer div
CDNRae Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 8 additions & 9 deletions docs/_includes/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<link rel="stylesheet" href="css/normalize.css" />
<link rel="stylesheet" href="css/style.css" />
<link rel="stylesheet" href="css/prism.css" />
<link rel="shortcut icon" href="favicon.ico" />
<link rel="icon" href="favicon.ico" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW you can remove the /> from the HTML tags here. It's not needed in HTML5+.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention, shortcut icon is needed for old IE. Which AFAICT since html5shiv is loaded, it is still supported.

If not, that's OK, but both should be dropped.


<!--[if lt IE 9]> <script src="js/html5shiv.min.js"></script> <![endif]-->
</head>
Expand All @@ -23,10 +23,9 @@
<h1>
<a href="/">
<img
id="mocha-logo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use an ID for targeting this. Just a logo class or something.

src="/images/mocha-logo.svg"
alt="Mocha"
width="192"
height="192"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the dimensions; the HTML is rendered first so it's always better to have the dimensions here.

alt="Mocha logo"
/>
</a>
</h1>
Expand All @@ -37,15 +36,15 @@ <h1>
<main id="content">{{ content }}</main>

<footer>
<span>
<a href="https://mochajs.org">mochajs.org</a> is licensed under a
<a rel="license" href="http://creativecommons.org/licenses/by/4.0/"
<div>
<a rel="home" href="https://mochajs.org">mochajs.org</a> is licensed under a
<a rel="license external noopener" href="http://creativecommons.org/licenses/by/4.0/"
>Creative Commons Attribution 4.0 International License</a
>.
<p>
<em>Last updated: {{ 'now' | date: '%a %b %d %H:%M:%S %Y' }}</em>
</p></span
>
</p>
</div>
</footer>
</body>
</html>
7 changes: 6 additions & 1 deletion docs/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ header {
padding-top: 20px;
}

#mocha-logo {
width:192px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moot if you just keep the dimensions in the HTML, which IMO is better.

height:192px;
}

#content {
padding-bottom: 60px;
}
Expand Down Expand Up @@ -195,7 +200,7 @@ footer {
border-top: 1px solid #ddd;
}

footer span {
footer div {
display: block;
margin-right: 30px;
color: #888;
Expand Down