Fixes Parts of #3783 #3784
Fixes Parts of #3783 #3784
Conversation
|
Needs tweek to stylesheet to match what was there... change footer div { |
plroebuck
added
area: documentation
| @@ -23,10 +23,9 @@ | |||
| <h1> | |||
| <a href="/"> | |||
| <img | |||
| id="mocha-logo" | |||
There was a problem hiding this comment.
I wouldn't use an ID for targeting this. Just a logo class or something.
| src="/images/mocha-logo.svg" | ||
| alt="Mocha" | ||
| width="192" | ||
| height="192" |
There was a problem hiding this comment.
Keep the dimensions; the HTML is rendered first so it's always better to have the dimensions here.
| @@ -39,6 +39,11 @@ header { | |||
| padding-top: 20px; | |||
| } | |||
|
|
|||
| #mocha-logo { | |||
| width:192px; | |||
There was a problem hiding this comment.
This is moot if you just keep the dimensions in the HTML, which IMO is better.
| @@ -13,7 +13,7 @@ | |||
| <link rel="stylesheet" href="css/normalize.css" /> | |||
| <link rel="stylesheet" href="css/style.css" /> | |||
| <link rel="stylesheet" href="css/prism.css" /> | |||
| <link rel="shortcut icon" href="favicon.ico" /> | |||
| <link rel="icon" href="favicon.ico" /> | |||
There was a problem hiding this comment.
BTW you can remove the /> from the HTML tags here. It's not needed in HTML5+.
There was a problem hiding this comment.
Forgot to mention, shortcut icon is needed for old IE. Which AFAICT since html5shiv is loaded, it is still supported.
If not, that's OK, but both should be dropped.
Description of the Change
Fixes some issues outlined in #3783.
externalattribute to the link to the Creative Commons Licenseshortcutattribute from the favicon.Alternate Designs
N/A
Why should this be in core?
N/A
Benefits
It improves the website.
Removes meaningless attributes while updating HTML/CSS to more modern standards.
Possible Drawbacks
None to knowledge.
Applicable issues
Partial #3783.
semver-patch