Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer go doc #112

Closed
oliverpool opened this issue Dec 11, 2022 · 5 comments
Closed

Nicer go doc #112

oliverpool opened this issue Dec 11, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@oliverpool
Copy link

Congrats on the v2 release !

The go doc could look better, with the following improvements:

@mochi-co
Copy link
Collaborator

Thanks @oliverpool! I have implemented your suggestions as v2.0.2 - hopefully it fixes the issue once pkg.go.dev recaches.

@mochi-co mochi-co self-assigned this Dec 11, 2022
@mochi-co mochi-co added the enhancement New feature or request label Dec 11, 2022
@oliverpool
Copy link
Author

👍🏼
https://github.com/mochi-co/mqtt/blob/v2.0.2/fanpool.go is still missing a newline

@oliverpool
Copy link
Author

To preview the documentation locally, you can use the godoc cli (I also wrote an http documentation renderer: https://code.pfad.fr/vanitydoc , which should show a similar output)

@mochi-co
Copy link
Collaborator

Ahh good catch! Should now be fixed, so I've issued the v2.0.2 release with these changes. I can't check locally right now but hopefully that resolves the remaining issue :)

@mochi-co
Copy link
Collaborator

Looks like this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants