Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MQTT 5 protocol #65

Closed
mary-ng5519 opened this issue Apr 9, 2022 · 6 comments
Closed

Support MQTT 5 protocol #65

mary-ng5519 opened this issue Apr 9, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@mary-ng5519
Copy link

Folks, we love your work, please help support MQTT 5 protocol,
Cheers,

@mochi-co mochi-co added the enhancement New feature or request label Apr 10, 2022
@mochi-co mochi-co self-assigned this Apr 10, 2022
@saeidakbari
Copy link

For the reference this has a very good implementation of MQTT V5.

@wind-c
Copy link
Contributor

wind-c commented Sep 10, 2022

Support MQTT 5 protocol And Cluster. May refer to https://github.com/wind-c/comqtt .

@torntrousers
Copy link
Collaborator

Support MQTT 5 protocol And Cluster. May refer to https://github.com/wind-c/comqtt .

would be great for us users if a way could be found to have those updates in comqtt merged back here to this project

@mochi-co
Copy link
Collaborator

@torntrousers I will definitely be having a deeper look at @wind-c 's implementation of some of these features. I am very impressed what they have accomplished.

For mochi-co/mqtt it's important to consider the purpose of the library - which was (originally) to provide a minimalist, high performance embeddable library. We've aimed for the smallest, simplest amount of code possible in order to achieve these goals, so when it comes to features like clustering, there's a lot to consider.

I do think it would be nice to add these features, but they need to be balanced against maintainability and performance - and there's a few areas nin the existing codebase we need to improve first (like #101) :)

@torntrousers
Copy link
Collaborator

torntrousers commented Sep 11, 2022

For sure, all good for me and thats why we use your project.

@mochi-co
Copy link
Collaborator

Resolved in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants