Remove tuple calls #215
Merged
Remove tuple calls #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
force-pushed
the
remove-tuple-calls
branch
from
61591d1
to
5ae2f0a
Compare
```erlang
lists:foreach(
fun (F) -> erl_tidy:file(F, [{backups, false}, keep_unused]) end,
string:split(
string:trim(
os:cmd("git diff --name-only origin/master | grep \".erl$\"")
),
"\n",
all
)
).
```
nickva
approved these changes
Mar 12, 2019
There was a problem hiding this comment.
Looks good!
I also ran tests on 22.0-rc1 and those pass as well.
One minor thing I noticed is that there is a mix of tabs and spaces in some files. Not sure if there is an official formatting guide but it looks betters in some editors to have just one. (Just spaces is probably the more popular choice).
|
The mixed tabs and spaces are probably emacs erlang-mode's fault (historically). Do these modified files have mixed tabs and spaces? I ran erl_tidy on everything that changed (ideally settling on this or a similar tool on a CI basis, but didn't want to inflate this PR beyond things it touched). 69d6df7 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a re-implementation of part of #201, this removes tuple calls entirely from the source code, but I refactored the tests last to ensure that backwards compatibility is maintained.
Re: #214