-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTP 21 integration #201
OTP 21 integration #201
Conversation
cc @etrepum thoughts? |
My primary concern is just backwards compatibility. If this requires changes to usage we’re going to need to document it well. Maybe have a deprecation period? Haven’t had the time to go through and audit it myself yet. |
I’m away all week and probably won’t have a chance, if someone else looks into this we could get it merged more quickly. |
@sebastiw why templates are move to support? Maybe this could be made as a separate issue to focus on Erlang 21? |
the whole support-dir is moved to priv/ because of https://github.com/mochi/mochiweb/pull/201/files#diff-a8c3e747ab3f8a14dc6605125a437097R7 |
but yeah, the useage of that is only within testing. |
I'm going to close this PR as we have other more minimal PRs that provide OTP 21 compatibility. It looks like there may be some future improvements we can make, but I would prefer to have each in separate PRs to make it easier to test and review. |
Solves #199