Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTP 21 integration #201

Closed
wants to merge 3 commits into from
Closed

OTP 21 integration #201

wants to merge 3 commits into from

Conversation

sebastiw
Copy link

Solves #199

@benoitc
Copy link
Collaborator

benoitc commented Jul 30, 2018

cc @etrepum thoughts?

@etrepum
Copy link
Member

etrepum commented Aug 3, 2018

My primary concern is just backwards compatibility. If this requires changes to usage we’re going to need to document it well. Maybe have a deprecation period?

Haven’t had the time to go through and audit it myself yet.

@etrepum
Copy link
Member

etrepum commented Aug 7, 2018

I’m away all week and probably won’t have a chance, if someone else looks into this we could get it merged more quickly.

@benoitc
Copy link
Collaborator

benoitc commented Aug 8, 2018

@sebastiw why templates are move to support? Maybe this could be made as a separate issue to focus on Erlang 21?

@sebastiw
Copy link
Author

sebastiw commented Aug 8, 2018

the whole support-dir is moved to priv/ because of ssl_cert_opts/0 and the use of code:priv_dir/1

https://github.com/mochi/mochiweb/pull/201/files#diff-a8c3e747ab3f8a14dc6605125a437097R7

@sebastiw
Copy link
Author

sebastiw commented Aug 8, 2018

but yeah, the useage of that is only within testing.

@etrepum
Copy link
Member

etrepum commented Jan 16, 2019

I'm going to close this PR as we have other more minimal PRs that provide OTP 21 compatibility. It looks like there may be some future improvements we can make, but I would prefer to have each in separate PRs to make it easier to test and review.

@etrepum etrepum closed this Jan 16, 2019
@etrepum etrepum mentioned this pull request Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants