Equipotential plotting #3626
Equipotential plotting #3626
Conversation
…Principia into equipotential-plotting
|
|
||
| struct Equipotentials { | ||
| Equipotential<Barycentric, Navigation>::Lines lines; | ||
| Parameters parameters; |
There was a problem hiding this comment.
It feels a bit odd to return the parameters.
There was a problem hiding this comment.
Yes, but because of the asynchronicity we need them to know whether we can use the result.
| if (plotter_idle_) { | ||
| plotter_idle_ = false; | ||
| plotter_ = MakeStoppableThread( | ||
| [this, parameters]() { PlotEquipotentials(parameters).IgnoreError(); }); |
There was a problem hiding this comment.
We generally don't write bodies on a single line, so line breaks after { and before }.
There was a problem hiding this comment.
We do for λs.
Principia/base/recurring_thread_body.hpp
Line 29 in 3fcf46c
| &t](Position<Navigation> const& position) { | ||
| auto const acceleration = reference_frame.GeometricAcceleration( | ||
| t, {position, Velocity<Navigation>{}}); | ||
| // Note the sign. |
There was a problem hiding this comment.
I noted it, but maybe explain why it's there.
There was a problem hiding this comment.
Done, and renamed the λ.
| int __cdecl principia__EquipotentialCount(Plugin* const plugin) { | ||
| journal::Method<journal::EquipotentialCount> m({plugin}); | ||
| CHECK_NOTNULL(plugin); | ||
| plugin->geometric_potential_plotter().RefreshEquipotentials(); |
There was a problem hiding this comment.
Why do we refresh if we are not in a rotating pulsating frame? That seems wasteful.
There was a problem hiding this comment.
RefreshEquipotentials isn’t RequestEquipotentials (the terminology is the same as in the analyser), the most it does is a swap.
…Principia into equipotential-plotting
#3358.