Master #1599
Closed
Master #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to Gradle 3.0
Update generated pom.xml with more project information
AssertJ 3 requires Java 8 and was therefore a breaking change, but there are no other changes breaking our test suite.
Also renamed misspelled isSussessful() to isSuccessful(). Added missing new line at the end of FailureDetector. Fixes: #653.
Fixing the typo in JUnitDetecter class name
[ci skip]
Upgrade to Gradle 3.1
[skip ci]
…eIsConfusingMockitoTest which had been added already (#673)
[ci skip] After publishing from release/2.x manually updated the release notes.
[ci skip]
…pilation problems Fixes #715
* Add missing newlines at the end of source files
At the time this patch was authored, 252 (~31%) source files in the
project did not end with a newline, while 555 (~69%) did.
This patch takes the de-facto standard of having a newline at the end
of a file and applies it to all the source files in the project.
Besides improving standardization, another contributing consideration
is the fact that many editors/IDEs add newlines at the end of files.
Using such an IDE will add a newline to the edited file, adding
"noise" to the patch and confusing potential reviewers. By explicitly
adding all the missing newlines in a single patch, this problem can be
avoided.
These changes were done automatically by applying the following shell
command:
$ find . -name "*.java" -exec sed -i -e '$a\' {} \;
* Remove whitespaces at the end of source lines
This patch takes the de-facto standard of not having any whitespaces
at the end of source lines and applies it to all the source files in
the project.
Besides improving standardization, another contributing consideration
is the fact that many editors/IDEs remove such whitespaces at end of
lines. Using such an IDE will remove these whitespaces in the edited
file, adding "noise" to the patch and confusing potential reviewers.
By explicitly removing all of them in a single patch, this problem can
be avoided.
These changes were done automatically by applying the following shell
command:
$ find . -name "*.java" -exec sed -i 's/[ \t]*$//' {} \;
master branch: Fix JavaDoc generation on recent JDK 8 builds (#934)
Stack trace in JDK part contains also module name
Could be propagated by the way also in other places.
Fix test failing with Java 9-ea+146+
Sample usage of soft assertions
[ci maven-central-release]
The original value in master branch was isNull(). Maybe that behavior can be different if compiled with Java 6 compatibility.
Also bump Build Scan version for Gradle 4 compatibility.
Backport fixes of release/2.x to master
Backport fixes from release/2.x to master
Backport fixes release/2.x to master
as opposed to VerificationAfterDelay, VerificationWithTimout doesn't support never()
replace parameters with arguments
|
This should not be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check list
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant