This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
ComparePublications working for Gradle plugins #419 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockitoguy
approved these changes
Oct 2, 2017
| @@ -8,6 +8,9 @@ apply plugin: 'com.gradle.plugin-publish' | |||
|
|
|||
| apply from: "$rootDir/gradle/upgrade-downstream.gradle" | |||
|
|
|||
| //TODO: WW uncomment when GradlePluginArtifactUrlResolver is released | |||
| //apply plugin: 'org.shipkit.compare-publications' | |||
There was a problem hiding this comment.
Why don't we fold it under 'org.shipkit.gradle-plugin'? It's already very opinionated by design.
|
|
||
| public class DefaultArtifactUrlResolverFactory { | ||
|
|
||
| public DefaultArtifactUrlResolver getDefaultResolver(Project project, String artifactBaseName, String previousVersion) { | ||
| if (project.getPlugins().hasPlugin(ShipkitBintrayPlugin.class)) { | ||
| return new BintrayDefaultArtifactUrlResolver(project, artifactBaseName, previousVersion); | ||
| } else if (project.getPlugins().hasPlugin(GradlePortalPublishPlugin.class)) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it locally. It seems that there is always a difference in poms but since this is not a critical situation, we can test if the same problem occurs on Travis.