Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.x] Revise MODCLUSTER-332 fix. #40

Merged
merged 1 commit into from Aug 30, 2013

Conversation

Projects
None yet
2 participants
@pferraro
Copy link
Member

commented Aug 29, 2013

Remove unused Engine.getBackgroundProcessorDelay() method.
Replace ambiguous org.jboss.modcluster.container.catalina.WAITSTATUS system property with more intuitive org.jboss.modcluster.container.catalina.status-interval property.
Convert tab indentation to spaces.

@pferraro

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2013

This is what our documentation for Tomcat says to configure the status interval! If we can't change BackgroundProcessorDelay then we should be using our own thread.

@jfclere

This comment has been minimized.

Copy link
Member

commented Aug 29, 2013

"This is what our documentation for Tomcat says to configure the status interval!" Where I need to fix that.

Revise MODCLUSTER-332 fix.
Remove unused Engine.getBackgroundProcessorDelay() method.
Replace ambiguous org.jboss.modcluster.container.catalina.WAITSTATUS system property with more intuitive org.jboss.modcluster.container.catalina.status-frequency property which indicates the frequency with switch to perform STATUS processing with respect to the backgroundProcessorDelay..
Convert tab indentation to spaces.
@pferraro

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2013

OK - I've reimplemented this to use a "org.jboss.modcluster.container.catalina.status-frequency" system property which will perform STATUS processing every Nth interval, where N defaults to 1. This is similar to the logic used in the old HAModClusterService.

@pferraro

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2013

@jfclere I guess this isn't in our main documentation, but rather is documented the comments of the the configuration file we ship for AS5/6 integration: https://github.com/modcluster/mod_cluster/blob/master/src/main/resources/mod_cluster-jboss-beans.xml

We should probably remove this file altogether at some point...

@jfclere

This comment has been minimized.

Copy link
Member

commented Aug 29, 2013

OK I will merge that later and adjust the JIRA.

jfclere added a commit that referenced this pull request Aug 30, 2013

Merge pull request #40 from pferraro/1.2.x
[1.2.x] Revise MODCLUSTER-332 fix.

@jfclere jfclere merged commit 87b0919 into modcluster:1.2.x Aug 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.