MODCLUSTER-738 Remove service loader mechanism which was in place to … #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
force-pushed
the
MODCLUSTER-738
branch
from
cfd7ff6
to
3ec036b
Compare
rhusar
commented
Nov 23, 2021
...mcat-10.0/src/main/java/org/jboss/modcluster/container/tomcat/TomcatEventHandlerAdapter.java
Outdated
Show resolved
Hide resolved
pferraro
reviewed
Nov 23, 2021
...mcat-10.0/src/main/java/org/jboss/modcluster/container/tomcat/TomcatEventHandlerAdapter.java
Outdated
Show resolved
Hide resolved
pferraro
reviewed
Nov 23, 2021
...rc/test/java/org/jboss/modcluster/container/tomcat/ContainerEventHandlerAdapterTestCase.java
Outdated
Show resolved
Hide resolved
rhusar
commented
Nov 23, 2021
...rc/test/java/org/jboss/modcluster/container/tomcat/ContainerEventHandlerAdapterTestCase.java
Outdated
Show resolved
Hide resolved
rhusar
commented
Nov 23, 2021
...rc/test/java/org/jboss/modcluster/container/tomcat/ContainerEventHandlerAdapterTestCase.java
Outdated
Show resolved
Hide resolved
…support code sharing between Tomcat modules
rhusar
force-pushed
the
MODCLUSTER-738
branch
from
3ec036b
to
e44cb55
Compare
pferraro
approved these changes
Nov 24, 2021
|
Thanks @pferraro – was running a couple of tests and thing seem to be working alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…support code sharing between Tomcat modules
Resolves
https://issues.redhat.com/browse/MODCLUSTER-738