Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unit of permeability to V.s/(A.m) #3811

Merged
merged 1 commit into from
May 22, 2021
Merged

Change unit of permeability to V.s/(A.m) #3811

merged 1 commit into from
May 22, 2021

Conversation

dietmarw
Copy link
Member

Fixes #3295

@dietmarw dietmarw self-assigned this May 20, 2021
@dietmarw dietmarw added L: Constants Issue addresses Modelica.Constants L: Units Issue addresses Modelica.Units labels May 20, 2021
@dietmarw dietmarw added this to the MSL4.1.0 milestone May 20, 2021
AHaumer
AHaumer approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, quantity and unit of mu_0 were missing ...

christiankral
christiankral approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very much in favor of this change

@AHaumer AHaumer merged commit 39fe805 into modelica:master May 22, 2021
@beutlich beutlich assigned AHaumer and unassigned dietmarw May 22, 2021
@dietmarw dietmarw deleted the 3295-unit-of-permeability branch May 25, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiankral christiankral christiankral approved these changes

@AHaumer AHaumer AHaumer approved these changes

Assignees

@AHaumer AHaumer

Labels
L: Constants Issue addresses Modelica.Constants L: Units Issue addresses Modelica.Units
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

Unit of permeability
3 participants
@dietmarw @christiankral @AHaumer