-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wrapAngle.mo #3975
Update wrapAngle.mo #3975
Conversation
Bracket typos in function description and documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is invalid since the documentation is correct it with respect that the range does not include the lower -pi or the upper 2*pi. Hence ]-pi,pi]
and [0,2*pi[
are correct.
One could argue though that the non-standard |
Both variants are supposed to be standard notation. |
Ah ok, in that case Wolfram ought to update its pages ;-) https://mathworld.wolfram.com/OpenInterval.html Anyway, I would close this PR as invalid but leave the decision to the library officers @AHaumer and @MartinOtter |
As a plain vanilla user, the notation |
Yes, I understand. As I said, it is just a less common notation used in the documentation that what one would expect a normal user to know. Perhaps, adding a clarification could be better than modifying the existing text? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[-pi,pi] is wrong.
I'm comfortable both with ]-pi,pi] and (-pi,pi].
So use on of the two formulations.
OK, depending on this discussion I propose:
I am adding the link to the block and the function. |
Add link to Wikipedia
Bracket typos in function description and documentation.