Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

Allow FMUs to require start values #38

Open
t-sommer opened this issue Feb 27, 2019 · 7 comments
Open

Allow FMUs to require start values #38

t-sommer opened this issue Feb 27, 2019 · 7 comments

Comments

@t-sommer
Copy link
Collaborator

Often simulations fail because start values are not being set correctly (e.g. in the wrong state). It would be good to optionally allow test FMUs to specify start values that have to be set in order to reproduce the reference results e.g. as an (optional) file StartValues.csv:

OutsideTempC,18.5
InitialPosition[1],4
InitialPosition[2],1
InitialPosition[3],0
StringParam,"FMI is awesome!"

Tunable parameters could be provided via the existing *_in.csv. These changes would not require any updates of the existing FMUs and results.

@KarlWernersson
Copy link
Contributor

The default start values given in the xml has to be included in the compiled or the source code fmu.
It would be much easier to require FMU's to be exported with the default start values. For me this is obvious but maybe we need to spell it out?

@KarlWernersson
Copy link
Contributor

As there is no current way of specifying different start values of the FMU in the cross check, an FMU that requires a different set than the default is not compliant with the cross check rules

@t-sommer
Copy link
Collaborator Author

The point is to test if different start values are set correctly by the importing tool. If an FMU has different start values compiled in than what is in the XML it's simply illegal and should be excluded from the cross-check.

@KarlWernersson
Copy link
Contributor

Would people export such fmu's? Potentially make it harder for them to get passed by vendors not handling it correctly?
How much extra work would it be for importers to handle this in the import?
I see it more of interest as a reference fmu test rather than a compliance test.

@chrbertsch
Copy link
Contributor

chrbertsch commented Feb 27, 2019

This would indeed be an ideal case for "ReferenceFMUs" not exported by a commercial tool, but with the expectation that every tool can simulate them correctly (or explain why start value cannot be set in this tool). But in order to include this in the XC, we have to extend the XC infrastructure to support this.

@t-sommer
Copy link
Collaborator Author

That is exactly the intention of the Feedthrough Test-FMU.

@t-sommer
Copy link
Collaborator Author

t-sommer commented Mar 7, 2019

Discussion at Design Meeting Regensburg: Good idea.
Should be limited it to fixed and tunable parameters.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants