Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing space in command continuation request response #7

Open
duesee opened this issue Oct 11, 2023 · 1 comment
Open

Missing space in command continuation request response #7

duesee opened this issue Oct 11, 2023 · 1 comment
Labels
AFFECTED=public-inbox-imapd Project website: https://public-inbox.org/public-inbox.git PROTO=IMAP Related to IMAP protocol STATE=REPRODUCED Issue could be reproduced (explained in issue)

Comments

@duesee
Copy link
Contributor

duesee commented Oct 11, 2023 •
edited
Loading

https://github.com/jonhoo/rust-imap/blob/5d0d2f9723b626770ffeab7e334ded67ae94fd7e/src/client.rs#L472
@duesee duesee changed the title Add IMAP +\r\n defect. Missing space and text in command continuation request response May 11, 2024
@duesee duesee added PROTO=IMAP Related to IMAP protocol STATE=REPRODUCED Issue could be reproduced (explained in issue) labels May 11, 2024
@duesee duesee changed the title Missing space and text in command continuation request response Command continuation request response misses space and text May 11, 2024
@duesee duesee changed the title Command continuation request response misses space and text Missing space (and text) in command continuation request response May 11, 2024
@epilys epilys added the AFFECTED=public-inbox-imapd Project website: https://public-inbox.org/public-inbox.git label Jun 25, 2024
@epilys
Copy link
Member

epilys commented Jun 25, 2024 •
edited
Loading

Observed with public-inbox-imapd, probably affecting all versions including latest tagged one v1.9.0. Permalink

sub cmd_authenticate ($$$) {
	my ($self, $tag) = @_; # $method = $_[2], should be "ANONYMOUS"
	$self->{-login_tag} = $tag;
	"+\r\n"; # challenge
}

EDIT: Patch available, waiting for review.

EDIT: Patch merged 7bdfb48c3f2c1084f2a7112e039bc0ca0d42c1c1

@duesee duesee changed the title Missing space (and text) in command continuation request response Missing space in command continuation request response Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AFFECTED=public-inbox-imapd Project website: https://public-inbox.org/public-inbox.git PROTO=IMAP Related to IMAP protocol STATE=REPRODUCED Issue could be reproduced (explained in issue)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epilys @duesee