Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null reference access in addDetailedAppControls #63

Merged
merged 1 commit into from
Dec 13, 2022
Merged

fix null reference access in addDetailedAppControls #63

merged 1 commit into from
Dec 13, 2022

Conversation

withmorten
Copy link

Just used this program to run over a solution, and it threw an exception in this specific line: o.Screen() returned null.

By swapping where the Equals is called upon this exception no longer triggers and the program seems to run fine.

However since I don't know the architecture of this program, there could be a better fix, or this fix could have even more unintended side effects ... if there is, please let me know!

@modery
Copy link
Owner

modery commented Dec 13, 2022

That's an interesting issue - seems like you have a control somewhere that is not on any screen - but it also isn't the app itself or the screen itself.
The fix looks good, thanks for this!

@modery modery merged commit bcdcd51 into modery:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants