Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory_usage() for transposed dataframes #662

Conversation

williamma12
Copy link
Collaborator

What do these changes do?

memory_usage() for transposed dataframes was broken. This fixes the error

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #662 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage    90.5%   90.51%   +0.01%     
==========================================
  Files          37       37              
  Lines        5613     5620       +7     
==========================================
+ Hits         5080     5087       +7     
  Misses        533      533
Impacted Files Coverage Δ
modin/backends/pandas/query_compiler.py 92.3% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e56c0...381d4e2. Read the comment docs.

@williamma12 williamma12 added the Blocked ❌ A pull request that is blocked label Jun 10, 2019
@williamma12
Copy link
Collaborator Author

Blocked on #663

@williamma12 williamma12 removed the Blocked ❌ A pull request that is blocked label Jun 11, 2019
@williamma12 williamma12 force-pushed the pandas/transposed_memory_usage branch from c4abffe to 09398d4 Compare June 11, 2019 20:03
modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved
@devin-petersohn devin-petersohn merged commit 43f8ec8 into modin-project:master Jun 14, 2019
@modin-bot
Copy link

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants