Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32U5 #82

Merged
merged 1 commit into from
Apr 4, 2022
Merged

STM32U5 #82

merged 1 commit into from
Apr 4, 2022

Conversation

rleh
Copy link
Member

@rleh rleh commented Apr 3, 2022

No description provided.

Comment on lines +9 to +19
ignored_devices = \
[
"STM32U59",
"STM32U5A",
]

def ignoreDevice(device_id: str) -> bool:
for ignore in ignored_devices:
if device_id.startswith(ignore):
return True
return False
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that is the best way to ignore some devices (here: STM32U5{95, 99, A5, A9}) that are not published (yet) and thus are missing datasheet and relevant information.

I my opinion I it not useful to generate device files for this devices so we should somehow ignore them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, doesn't look like we have a choice if the documents are not there. We could guess the memory layout, but then it'll just be a problem later.

@chris-durand
Copy link
Member

Looks like ST added yet another type of a completely different DMA implementation ...

Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rleh
Copy link
Member Author

rleh commented Apr 4, 2022

Looks like ST added yet another type of a completely different DMA implementation ...

Yes. I ignored DMA completely for now in order to get STM32U5 support merged soon and not to create another PR that will get marked as stale in a few weeks.

@rleh rleh mentioned this pull request Apr 4, 2022
13 tasks
@salkinium salkinium merged commit db6caed into modm-io:develop Apr 4, 2022
@rleh rleh deleted the feature/stm32u5 branch April 4, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants