Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STM32U5 #843

Merged
merged 4 commits into from Mar 13, 2023
Merged

Add STM32U5 #843

merged 4 commits into from Mar 13, 2023

Conversation

rleh
Copy link
Member

@rleh rleh commented Apr 4, 2022 •
edited

Add STM32U5 devices

Most work was already done in #800.

  • Update device files: STM32U5 modm-devices#82
  • Port RCC driver
  • Adapt other platform drivers: Core, Gpio, Uart
  • Adapt ADC platform driver: Untested Disable ADC for now
  • Adapt even more platform drivers
  • Nucleo-U575ZI-Q BSP
  • Add CI jobs
  • Add and test Nucleo-U575ZI-Q blink example
    • Test on real hardware
  • Unittest runner
    • Test on real hardware
  • Unambiguous names for all STM32 unittests (e.g. compile-nucleo-f411 -> compile-nucleo-f411re, ...)
  • OpenOCD config

To be implemented later

  • DMA (completely new DMA IP(s))
  • SPI (same "new" IP as used in STM32H7)

@rleh rleh added this to the 2022q2 milestone Apr 4, 2022
chris-durand
chris-durand requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/modm/board/nucleo144_arduino_u5.hpp Outdated Show resolved Hide resolved
src/modm/board/nucleo144_arduino_u5.hpp Outdated Show resolved Hide resolved
src/modm/board/nucleo144_arduino_u5.hpp Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.cpp.in Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.cpp.in Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/core/stm32/startup_platform.c.in Outdated Show resolved Hide resolved
salkinium
salkinium reviewed Apr 4, 2022
View reviewed changes
examples/nucleo_u575zi-q/blink/project.xml Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.cpp.in Outdated Show resolved Hide resolved
chris-durand
chris-durand requested changes Apr 4, 2022
View reviewed changes
src/modm/platform/clock/stm32/rcc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.cpp.in Outdated Show resolved Hide resolved
@chris-durand
Copy link
Member

chris-durand commented Apr 4, 2022 •
edited

CI fails ...

EXTINT driver needs separate_flags = target.family in ["g0", "l5", "u5"] in module.lb.

And target.platform == "stm32" and target.family in ["l5", "u5"] in platform/uart/cortex/itm.cpp.in:64

@rleh rleh modified the milestones: 2022q2, 2022q3 Jul 1, 2022
@salkinium salkinium removed this from the 2022q3 milestone Oct 1, 2022
@rleh rleh added this to the 2023q1 milestone Mar 7, 2023
@rleh rleh marked this pull request as ready for review March 12, 2023 17:20
@rleh rleh added the ci:hal Triggers the exhaustive HAL compile CI jobs label Mar 12, 2023
@rleh
Copy link
Member Author

rleh commented Mar 12, 2023

Finally done! 🙂
Tested on real hardware ✅
Ready to merge from my side 🏁

@rleh rleh added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Mar 12, 2023
@rleh rleh added the ci:hal Triggers the exhaustive HAL compile CI jobs label Mar 12, 2023
chris-durand
chris-durand approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rleh rleh removed the ci:hal Triggers the exhaustive HAL compile CI jobs label Mar 13, 2023
@rleh
Copy link
Member Author

rleh commented Mar 13, 2023

If you @salkinium want to review, I'll be happy to wait. Otherwise merge?

@salkinium
Copy link
Member

Yes, go ahead with the merge.

@rleh
Copy link
Member Author

rleh commented Mar 13, 2023

I forgot to enable the backup SRAM, that is now fixed.

The unittest runner successfully runs all 4862 tests. I'm going to merge later.

@rleh rleh added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Mar 13, 2023
salkinium
salkinium approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked it over in more detail, nice!

@rleh rleh mentioned this pull request Mar 13, 2023
Merged
@rleh rleh merged commit 8a3a20b into modm-io:develop Mar 13, 2023
@rleh rleh deleted the feature/stm32u5 branch March 13, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@chris-durand chris-durand chris-durand approved these changes

Assignees
No one assigned
Labels
example 🔑 feature 🚧
Milestone
2023q1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rleh @chris-durand @salkinium