Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The 'logs' does not work correctly #3200

Closed
XtoManuel opened this issue Sep 22, 2022 · 2 comments · Fixed by #3201
Closed

[BUG]: The 'logs' does not work correctly #3200

XtoManuel opened this issue Sep 22, 2022 · 2 comments · Fixed by #3201
Labels
maybe: bug An unconfirmed bug

Comments

@XtoManuel
Copy link

Bot Version

4.0.1

How are you hosting Modmail?

PM2

Error Logs

https://hastebin.com/rowogoheca.rb

Screenshots

image

Additional Information

When the 'logs' command is used, the bot does not send user data. The only thing that appears is that "The bot is typing"

@XtoManuel XtoManuel added the maybe: bug An unconfirmed bug label Sep 22, 2022
@Jerrie-Aries
Copy link
Contributor

Jerrie-Aries commented Sep 22, 2022

Yes, I can confirm this.

Maybe due to old logs don't have the title key saved into the database.
Will try to take a look.

Updated:
Confirmed that some of the old logs don't have the title key saved.
Tested it with eval command.
issue_3200

Using .get() method here would resolve the issue:
https://github.com/kyb3r/modmail/blob/ea8284859536584ce40585e64b0f3490a53b3641/cogs/modmail.py#L752-L753

i.e:

if entry.get("title"):

@StephenDaDev
Copy link
Member

Can-repo 4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe: bug An unconfirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants