Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in .gitify file are stripped out #434

Open
achterbahn opened this issue Apr 21, 2023 · 2 comments
Open

Comments in .gitify file are stripped out #434

achterbahn opened this issue Apr 21, 2023 · 2 comments

Comments

@achterbahn
Copy link

Summary

A gitify extract strips any comments # this is a comment from .gitify.
We often use some parts / partitions to comment out and use them again.

Step to reproduce

  • Add a comment in the .gitify file
  • `gitify extract``

Observed behavior

Comments are gone

Expected behavior

Comments are still in the .gitify file

Environment

Gitify version 2.0.1-pl

@Mark-H
Copy link
Member

Mark-H commented Apr 21, 2023

As a work-around, specifying --no-packages will avoid the file from getting rewritten, but thank you for logging this issue.

@hugopeek
Copy link
Contributor

hugopeek commented May 8, 2023

Also, options with multiple values are being reformatted into a single line array.

So this:

        where:
            - 'key:NOT IN':
                - 'site_url'
                - 'base_url'
                - 'http_host'

Becomes:

        where:
            - { 'key:NOT IN': [site_url, base_url, http_host] }

I didn't even know that that was possible in YAML, but it's not convenient with large arrays.

@modmore modmore deleted a comment from degoya Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants