Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update route can return older versions #2660

Open
Prospector opened this issue Feb 17, 2023 · 2 comments
Open

Update route can return older versions #2660

Prospector opened this issue Feb 17, 2023 · 2 comments
Labels
backend Relates to Modrinth Backend or API bug Something isn't working

Comments

@Prospector
Copy link
Member

Prospector commented Feb 17, 2023

Describe the bug

Edit: The example below is no longer the case because the author updated it, but at the time it was true.

For example, this mod: https://modrinth.com/mod/fastload/versions

The user is running version 2.6.11 (marked as Fabric) on Quilt. By giving the hash of that file to Modrinth's update route filtering for quilt mods, it will return version 2.6.10 because that is the latest version marked as Quilt on Modrinth. Modrinth should see that the given version is more recent than the latest Quilt version and return nothing for that, instead of suggesting an older version just because it fits the mod loader.

Perhaps a query param could be added to bypass this, but I think this should be the default as it would be the intended result in any case I can think of. An "update" route should never downgrade you.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

@Andre601
Copy link
Contributor

I think by default should the route ignore loaders (or maybe make fabric include quilt?) and have a loader query param to define the loaders to respect here...

@Prospector
Copy link
Member Author

pretty sure you just described the current behavior? The problem is that when you're requesting a Quilt mod but you're running a more recent version that isn't listed as supporting Quilt, it can suggest an old version trying to match the loader when it should just never return an older version no matter what loader the provided one is for.

@Prospector Prospector transferred this issue from modrinth/labrinth Oct 19, 2024
@Prospector Prospector added the backend Relates to Modrinth Backend or API label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Relates to Modrinth Backend or API bug Something isn't working
Development

No branches or pull requests

2 participants