-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Refactor uses of StaticTuple
to use InlineArray
#2514
Comments
Do you have any idea how to run the testing suite? Is the 'Test Examples' workflow comprehensive? |
@JoeLoser there are some differences between
|
Hi @artemiogr97, re. your second question:
Yes, it would be good for us to preserve a way to create uninitialized We may want to go a different direction down the line, but I think your suggestion for a |
[External] [stdlib] remove uses of StaticTuple where possible Fix for modularml#2514 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2583 --------- Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes modularml#2583 MODULAR_ORIG_COMMIT_REV_ID: 690cbe5148e583e1f86638f251fab93a1c72a948
[External] [stdlib] remove uses of StaticTuple where possible Fix for #2514 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=#2583 --------- Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes #2583 MODULAR_ORIG_COMMIT_REV_ID: 690cbe5148e583e1f86638f251fab93a1c72a948
Fixed with 6af1fa7. Thank you! |
[External] [stdlib] remove uses of StaticTuple where possible Fix for modularml#2514 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2583 --------- Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes modularml#2583 MODULAR_ORIG_COMMIT_REV_ID: 690cbe5148e583e1f86638f251fab93a1c72a948 Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
[External] [stdlib] remove uses of StaticTuple where possible Fix for #2514 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=#2583 --------- Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes #2583 MODULAR_ORIG_COMMIT_REV_ID: 690cbe5148e583e1f86638f251fab93a1c72a948
We recently got a generic array type (
InlineArray
) (see here) that works on memory-only types rather thanAnyRegType
likeStaticTuple
works on. So, conceptually,InlineArray
can replace all of these uses.This issue tracks doing the work of replacing uses of
StaticTuple
withInlineArray
so we can eventually removeStaticTuple
and then re-home theInlineArray
into thecollections
module where it belong.The text was updated successfully, but these errors were encountered: