[stdlib] Change FileHandle.read_bytes() to not copy data
#2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Mabrouk <mohamed.mabrouk@rwth-aachen.de>
JoeLoser
approved these changes
Apr 17, 2024
JoeLoser
changed the title
FileHandle.read_bytes() to not copy data
patrickdoc
added a commit
to patrickdoc/mojo
that referenced
this pull request
Apr 24, 2024
…odularml#2319) (#38182) Augment `FileHandle.read_bytes()` to not copy the data read when constructing the returned `List[Int8]` by leveraging the new constructor added in [Internal Link] Fixes modularml#2051 Signed-off-by: Mohamed Mabrouk <mohamed.mabrouk@rwth-aachen.de> mojo-orig-commit: 0b344fb --------- Co-authored-by: MoSafi2 [Internal Link] Co-authored-by: abdul dakkak <adakkak@modular.com> modular-orig-commit: fcb2f1457eb6f2eb5a1c371fbdf24fca74c308ce
jayzhan211
pushed a commit
to jayzhan211/mojo
that referenced
this pull request
Apr 27, 2024
…odularml#2319) (#38182) Augment `FileHandle.read_bytes()` to not copy the data read when constructing the returned `List[Int8]` by leveraging the new constructor added in [Internal Link] Fixes modularml#2051 Signed-off-by: Mohamed Mabrouk <mohamed.mabrouk@rwth-aachen.de> mojo-orig-commit: 0b344fb --------- Co-authored-by: MoSafi2 [Internal Link] Co-authored-by: abdul dakkak <adakkak@modular.com> modular-orig-commit: fcb2f1457eb6f2eb5a1c371fbdf24fca74c308ce
patrickdoc
added a commit
to patrickdoc/mojo
that referenced
this pull request
May 2, 2024
…odularml#2319) (#38182) Augment `FileHandle.read_bytes()` to not copy the data read when constructing the returned `List[Int8]` by leveraging the new constructor added in modularml#2182. Fixes modularml#2051 Signed-off-by: Mohamed Mabrouk <mohamed.mabrouk@rwth-aachen.de> mojo-orig-commit: 0b344fb --------- Co-authored-by: MoSafi2 <127411725+MoSafi2@users.noreply.github.com> Co-authored-by: abdul dakkak <adakkak@modular.com> MODULAR_ORIG_COMMIT_REV_ID: fcb2f1457eb6f2eb5a1c371fbdf24fca74c308ce
patrickdoc
added a commit
that referenced
this pull request
May 2, 2024
…2319) (#38182) Augment `FileHandle.read_bytes()` to not copy the data read when constructing the returned `List[Int8]` by leveraging the new constructor added in #2182. Fixes #2051 Signed-off-by: Mohamed Mabrouk <mohamed.mabrouk@rwth-aachen.de> mojo-orig-commit: 0b344fb --------- Co-authored-by: MoSafi2 <127411725+MoSafi2@users.noreply.github.com> Co-authored-by: abdul dakkak <adakkak@modular.com> MODULAR_ORIG_COMMIT_REV_ID: fcb2f1457eb6f2eb5a1c371fbdf24fca74c308ce
softmaxer
pushed a commit
to softmaxer/mojo
that referenced
this pull request
May 3, 2024
…odularml#2319) (#38182) Augment `FileHandle.read_bytes()` to not copy the data read when constructing the returned `List[Int8]` by leveraging the new constructor added in modularml#2182. Fixes modularml#2051 Signed-off-by: Mohamed Mabrouk <mohamed.mabrouk@rwth-aachen.de> mojo-orig-commit: 0b344fb --------- Co-authored-by: MoSafi2 <127411725+MoSafi2@users.noreply.github.com> Co-authored-by: abdul dakkak <adakkak@modular.com> MODULAR_ORIG_COMMIT_REV_ID: fcb2f1457eb6f2eb5a1c371fbdf24fca74c308ce Signed-off-by: Sriram Vadlamani <sriram.vadlamani@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2051, allows FileHandle.read_bytes() to return List[Int8] without additional copies, depends on #2182.