Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Change FileHandle.read_bytes() to not copy data #2319

Merged
merged 1 commit into from Apr 17, 2024
Merged

[stdlib] Change FileHandle.read_bytes() to not copy data #2319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions stdlib/src/builtin/file.mojo
View file
Open in desktop
Expand Up @@ -188,12 +188,7 @@ struct FileHandle:
if err_msg:
raise (err_msg^).consume_as_error()

var list = List[Int8](capacity=int(size_copy))
var list_ptr = UnsafePointer[Int8](address=int(list.data))

# Initialize the List elements and set the initialized size
memcpy(list_ptr, buf, int(size_copy))
list.size = int(size_copy)
var list = List[Int8](buf, int(size_copy), int(size_copy))

return list

Expand Down