[stdlib] Allow StringRef to work with both Int8 and UInt8
#2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
JoeLoser
added
imported-internally
JoeLoser
pushed a commit
that referenced
this pull request
May 3, 2024
…8 (#38989) [External] [stdlib] Allow `StringRef` to work with both Int8 and UInt8 This is related to #2317 This is similar to #2448 but for StringRef. With this, users and maintainers can work with both Int8 and UInt8 and will allow a graceful transition. This should also allow users to switch during the next release. Co-authored-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com> Closes #2454 MODULAR_ORIG_COMMIT_REV_ID: 4ef46b217579ad62ca22defc2d8a31930ef37c5a
|
🎉 🔥 This landed in tonight's nightly release in #2480! Thanks again for the contribution! |
lsh
pushed a commit
to lsh/mojo
that referenced
this pull request
May 17, 2024
…8 (#38989) [External] [stdlib] Allow `StringRef` to work with both Int8 and UInt8 This is related to modularml#2317 This is similar to modularml#2448 but for StringRef. With this, users and maintainers can work with both Int8 and UInt8 and will allow a graceful transition. This should also allow users to switch during the next release. Co-authored-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com> Closes modularml#2454 MODULAR_ORIG_COMMIT_REV_ID: 4ef46b217579ad62ca22defc2d8a31930ef37c5a Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
modularbot
pushed a commit
that referenced
this pull request
Jun 7, 2024
…8 (#38989) [External] [stdlib] Allow `StringRef` to work with both Int8 and UInt8 This is related to #2317 This is similar to #2448 but for StringRef. With this, users and maintainers can work with both Int8 and UInt8 and will allow a graceful transition. This should also allow users to switch during the next release. Co-authored-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com> Closes #2454 MODULAR_ORIG_COMMIT_REV_ID: 4ef46b217579ad62ca22defc2d8a31930ef37c5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2317
This is similar to #2448 but for StringRef.
With this, users and maintainers can work with both Int8 and UInt8 and will allow a graceful transition. This should also allow users to switch during the next release.