Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Support for negative indexes in List._reverse(start) method #2497

Closed
wants to merge 2 commits into from
Closed

[stdlib] Support for negative indexes in List._reverse(start) method #2497

wants to merge 2 commits into from

Conversation

msaelices
Copy link
Contributor

@msaelices msaelices commented May 3, 2024 •
edited

Changes

  • The _reverse(start) private method in the collections.List struct does not support negative indexes.
  • Check out-of-bound indexes in the List._reverse() method
  • Tests

Ref

Fixes #2496

@msaelices
[stdlib] Support for negative indexes in List._reverse(start) method
758f217 
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
@msaelices msaelices requested a review from a team as a code owner May 3, 2024 22:51
@msaelices
[stdlib] Check out-of-bound indexes in the List._reverse() method
60d5942 
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
@soraros soraros mentioned this pull request May 4, 2024
Closed
@msaelices
Copy link
Contributor Author

Closed in favor of #2520

@msaelices msaelices closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@msaelices