[stdlib] Support for negative indexes in List._reverse(start) method and out of bound validation
#2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
JoeLoser
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in 02aa519! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
May 16, 2024
…art)` method and out of bound validation (#39464) [External] [stdlib] Support for negative indexes in `List._reverse(start)` method and out of bound validation ## Changes * The `_reverse(start)` private method in the `collections.List` struct does not support negative indexes. * Check out-of-bound indexes in the `List._reverse()` method * Tests ## Ref Fixes #2496 --------- Co-authored-by: Manuel Saelices <msaelices@gmail.com> Co-authored-by: Connor Gray <code@connorgray.com> Closes #2520 MODULAR_ORIG_COMMIT_REV_ID: 2662cfba2e6c1a602e8fa11880f29f8add446506
lsh
pushed a commit
to lsh/mojo
that referenced
this pull request
May 17, 2024
…art)` method and out of bound validation (#39464) [External] [stdlib] Support for negative indexes in `List._reverse(start)` method and out of bound validation ## Changes * The `_reverse(start)` private method in the `collections.List` struct does not support negative indexes. * Check out-of-bound indexes in the `List._reverse()` method * Tests ## Ref Fixes modularml#2496 --------- Co-authored-by: Manuel Saelices <msaelices@gmail.com> Co-authored-by: Connor Gray <code@connorgray.com> Closes modularml#2520 MODULAR_ORIG_COMMIT_REV_ID: 2662cfba2e6c1a602e8fa11880f29f8add446506 Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
msaelices
added a commit
to msaelices/mojo
that referenced
this pull request
May 18, 2024
…art)` method and out of bound validation (#39464) [External] [stdlib] Support for negative indexes in `List._reverse(start)` method and out of bound validation ## Changes * The `_reverse(start)` private method in the `collections.List` struct does not support negative indexes. * Check out-of-bound indexes in the `List._reverse()` method * Tests ## Ref Fixes modularml#2496 --------- Co-authored-by: Manuel Saelices <msaelices@gmail.com> Co-authored-by: Connor Gray <code@connorgray.com> Closes modularml#2520 MODULAR_ORIG_COMMIT_REV_ID: 2662cfba2e6c1a602e8fa11880f29f8add446506
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…art)` method and out of bound validation (#39464) [External] [stdlib] Support for negative indexes in `List._reverse(start)` method and out of bound validation ## Changes * The `_reverse(start)` private method in the `collections.List` struct does not support negative indexes. * Check out-of-bound indexes in the `List._reverse()` method * Tests ## Ref Fixes modularml#2496 --------- Co-authored-by: Manuel Saelices <msaelices@gmail.com> Co-authored-by: Connor Gray <code@connorgray.com> Closes modularml#2520 MODULAR_ORIG_COMMIT_REV_ID: 2662cfba2e6c1a602e8fa11880f29f8add446506
modularbot
pushed a commit
that referenced
this pull request
Jun 7, 2024
…art)` method and out of bound validation (#39464) [External] [stdlib] Support for negative indexes in `List._reverse(start)` method and out of bound validation ## Changes * The `_reverse(start)` private method in the `collections.List` struct does not support negative indexes. * Check out-of-bound indexes in the `List._reverse()` method * Tests ## Ref Fixes #2496 --------- Co-authored-by: Manuel Saelices <msaelices@gmail.com> Co-authored-by: Connor Gray <code@connorgray.com> Closes #2520 MODULAR_ORIG_COMMIT_REV_ID: 2662cfba2e6c1a602e8fa11880f29f8add446506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
_reverse(start)private method in thecollections.Liststruct does not support negative indexes.List._reverse()methodRef
Fixes #2496