-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] add Defaultable
trait
#2526
Conversation
``` | ||
""" | ||
|
||
fn __init__(inout self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have the name default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can bikeshed the name another time. I'll bring it up in Monday's team meeting.
Signed-off-by: Max Brylski <helehex@gmail.com>
0771a45
to
64e8a1c
Compare
i simplified the docstring |
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <Helehex@gmail.com> Closes #2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425
Landed in 60f5b04! Thank you for your contribution 🎉 |
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425 Signed-off-by: rd4com <144297616+rd4com@users.noreply.github.com>
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425 Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425
[External] [stdlib] Add `Defaultable` trait Add a `Defaultable` trait for describing a type which has a constructor with no arguments. Co-authored-by: Helehex <Helehex@gmail.com> Closes #2526 MODULAR_ORIG_COMMIT_REV_ID: aed69a25ecf531873f944466a1cb5d7652dd7425
adds a
Defaultable
trait for describing a type which has a constructor with no arguments