-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] UTests for SIMD
's operators required by Comparable
#3221
Conversation
Testing the following dunder methods in `SIMD`: `__lt__`, `__le__`, `__eq__`, `__ne__`, `__gt__` and `__ge__`. Note that we test directly dunder methods to avoid any unintended implicit conversions possibly introduced trough operator syntax sugar. Partially resolves modularml#3145 Signed-off-by: Victor Guerra <vguerra@gmail.com>
As well, expanding asserts to avoid implict conversions and making sure `__ne__` dunder method is as well tested. Signed-off-by: Victor Guerra <vguerra@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
!sync |
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
…able` (#43826) [External] [stdlib] UTests for `SIMD`'s operators required by `Comparable` Testing the following dunder methods in `SIMD`: `__lt__`, `__le__`, `__eq__`, `__ne__`, `__gt__` and `__ge__`. Note that we test directly dunder methods to avoid any unintended implicit conversions possibly introduced trough operator syntax sugar. Partially resolves #3145 Co-authored-by: Victor Guerra <vguerra@gmail.com> Closes #3221 MODULAR_ORIG_COMMIT_REV_ID: 55ece3450c8b074ae3279f79cec8aa642382b036
Landed in 9a395fd! Thank you for your contribution 🎉 |
Testing the following dunder methods in
SIMD
:__lt__
,__le__
,__eq__
,__ne__
,__gt__
and__ge__
. Note that we test directly dunder methods to avoid any unintended implicit conversions possibly introduced trough operator syntax sugar.Partially resolves #3145