Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hide_children_in_tree for Collections that do not have containers as a child #13

Closed
theboxer opened this issue Dec 23, 2013 · 11 comments

Comments

@theboxer
Copy link
Member

This will prevent displaying arrow before the Collection node in Resource tree when it has only Resource children (that are all hidden under children's tab).

@theboxer
Copy link
Member Author

This will be available in next version of MODX, because there is no way to get it working in current version...

@exside
Copy link
Contributor

exside commented May 30, 2014

doh, there isn't?? I just tried that...setting the attribute "hide_children_in_tree" of the CollectionsContainer resource indeed hides the arrow... (this is not set "normally" though, e.g that attribute has value of 0, also when its a Collection)...I guess there's something that was a problem when doing so?

I just saw 3 different editors clicking on that arrow...that's why it seems to be an issue for me...

modx collections treearrow

@theboxer
Copy link
Member Author

The problem is, that when you set this property, you will not be able to drag and drop resource in collections....

@exside
Copy link
Contributor

exside commented May 31, 2014

shit...yap...any possibility to hide that arrow via css??

@theboxer
Copy link
Member Author

hmm, probably you can try it based on the collections (not sure how it's named in real, LOL) class that it has because of the collecions icon.

@labr1005
Copy link

This works for me in MODX 2.3.2 to hide those triangles via css:

[ext\:tree-node-id="web_269"] > i.x-tree-ec-icon.x-tree-elbow-plus {
    visibility: hidden;
}

where tree-node-id is "context" + "_" + "resource id".

@theboxer
Copy link
Member Author

If you'll have nested collections, or folder under collections, it will not work properly

@labr1005
Copy link

That's true. This is just a dirty fix for the case as described by exside. I currently have this situation, too, where there's nothing nested but the editors always click on the triangle.

@christianseel
Copy link

  1. Shouldn't modResources have the show_in_tree flag set to 0?

  2. Shouldn't MODX recognize if all children have the show_in_tree flag set to 0 and don't show the little arrow?

@theboxer
Copy link
Member Author

ad 1) resources under Collections have that flag set to 0
ad 2) yes it should :)

@christianseel
Copy link

Oops, (1) was a bug in Gitify (which is now fixed) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants