Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODX does not allow you to create/open an empty file #15976

Closed
Ruslan-Aleev opened this issue Jan 19, 2022 · 2 comments · Fixed by #15977 or #15985
Closed

MODX does not allow you to create/open an empty file #15976

Ruslan-Aleev opened this issue Jan 19, 2022 · 2 comments · Fixed by #15977 or #15985
Assignees
@Mark-H
Labels
bug The issue in the code or project, which should be addressed.
Milestone
v3.0.0-rc2

Comments

@Ruslan-Aleev
Copy link
Collaborator

Bug report

Summary

MODX does not allow you to create/open an empty file, even if the file is not created through the CMS.

Step to reproduce

Try to create an empty txt file and save it.

emptyFile

If you create an empty file on the server, then MODX will display the file in the tree, but will not allow you to open it.

Environment

MODX 3.0.0-rc1
@Ruslan-Aleev Ruslan-Aleev added the bug The issue in the code or project, which should be addressed. label Jan 19, 2022
@Mark-H Mark-H self-assigned this Jan 19, 2022
Mark-H added a commit to Mark-H/revolution that referenced this issue Jan 19, 2022
@Mark-H
Fix mpty files considered non-existant (modxcms#15976)
ebc19f9
@Mark-H Mark-H mentioned this issue Jan 19, 2022
Merged
@Mark-H Mark-H added this to the v3.0.0-rc2 milestone Jan 19, 2022
@opengeek opengeek linked a pull request Jan 19, 2022 that will close this issue
Fix empty files considered non-existant (#15976) #15977
Merged
@Mark-H Mark-H modified the milestones: v3.0.0-rc2, v3.0.0-rc1 Jan 19, 2022
@Mark-H
Copy link
Collaborator

Mark-H commented Jan 19, 2022

Fixed for rc1

@Mark-H Mark-H closed this as completed Jan 19, 2022
@Mark-H Mark-H reopened this Jan 21, 2022
@Mark-H
Copy link
Collaborator

Mark-H commented Jan 21, 2022

While it's possible to create now, I somehow overlooked the tree not allowing it to be clicked: #15977 (comment) 🤔

@Mark-H Mark-H modified the milestones: v3.0.0-rc1, v3.0.0-rc2 Jan 21, 2022
@Mark-H Mark-H mentioned this issue Jan 21, 2022
Merged
@JoshuaLuckers JoshuaLuckers linked a pull request Jan 23, 2022 that will close this issue
Fix empty files not being clickable in the file tree (#15976) #15985
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mark-H Mark-H

Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
v3.0.0-rc2
3 participants
@Mark-H @theboxer @Ruslan-Aleev