Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty files not being clickable in the file tree (#15976) #15985

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

Mark-H
Copy link
Collaborator

@Mark-H Mark-H commented Jan 21, 2022

What does it do?

  • Adds a debug log statement so we can inspect the mime types of files more easily in the future
  • Considers application/x-empty as a non-binary file type
  • Fixes PHP warning: Undefined array key "Orientation" warning for each image in the tree lacking that Exif header

Why is it needed?

Fix empty files not being clickable in the file tree, due to unrecognised application/x-empty mime type

How to test

#15977 (comment)

Related issue(s)/PR(s)

Fixes #15976 (again)

@Mark-H Mark-H added this to the v3.0.0-rc2 milestone Jan 21, 2022
@Mark-H Mark-H requested a review from opengeek as a code owner January 21, 2022 16:14
@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jan 21, 2022
@muzzwood
Copy link
Contributor

Just tested this. It works for me 👍🏻

@JoshuaLuckers JoshuaLuckers linked an issue Jan 23, 2022 that may be closed by this pull request
@JoshuaLuckers JoshuaLuckers added the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Jan 23, 2022
Co-authored-by: Joshua Lückers <joshualuckers@me.com>
@opengeek opengeek merged commit 38ab332 into modxcms:3.x Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MODX does not allow you to create/open an empty file
4 participants