Fix empty files considered non-existant (#15976) #15977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opengeek
approved these changes
Jan 19, 2022
|
It's working as expected here with the patch. Is the file readable? |
|
Readable, it seems. I can create a file, it opens when saving. But if I close it, I won't be able to open it again.
p.s. I have Windows OS, can this be the case? |
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes a logic issue in the media source implementation.
Why is it needed?
Relying on
read()limits the functionality to files that can be read. But readable files may still exist and should be editable.How to test
Create an empty file and try to edit it. Note MODX shows the "File doesn't exist!" error. Apply patch, try again.
Related issue(s)/PR(s)
#15976