Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced install & renamed assets folder #5997

Closed
modxbot opened this issue Nov 3, 2011 · 6 comments
Closed

Advanced install & renamed assets folder #5997

modxbot opened this issue Nov 3, 2011 · 6 comments
Labels
area-setup bug The issue in the code or project, which should be addressed.
Milestone
Revolution-2.2.0-rc3

Comments

@modxbot
Copy link
Contributor

modxbot commented Nov 3, 2011

romain created Redmine issue ID 5997

On an advanced install where the assets folder has been renamed, the folders assets/components/ keeps being created after an upgrade.
@modxbot
Copy link
Contributor Author

modxbot commented Nov 3, 2011

romain submitted:

After trying to understand, i guess that stands in the modinstall.class.php, line 403/404

@splittingred
Copy link

splittingred submitted:

Fixed: 955e278

@modxbot
Copy link
Contributor Author

modxbot commented Dec 16, 2011

romain submitted:

Actually that issue happens.

Consider the following install:

/folder/
/folder/core/
/folder/webroot/
/folder/webroot/a/ (renamed assets folder)

Each time i upgrade, i end up having a "/folder/webroot/assets/components/" created. Furthermore, when installing a new component after the upgrade, the assets files end in /assets/components/ while the previous installed components' assets are still in /a/components/

@splittingred
Copy link

splittingred submitted:

It still happens?

@modxbot
Copy link
Contributor Author

modxbot commented Dec 16, 2011

romain submitted:

Yes sir. Still occurs might have been a better word, sorry.

@splittingred
Copy link

splittingred submitted:

Fixed: 9b270fc

danyaPostfactum pushed a commit to danyaPostfactum/revolution that referenced this issue Mar 27, 2014
@opengeek
MODX Revolution 2.2.0-rc3
8be8b69 
Merge branch 'release-2.2'

* release-2.2: (33 commits)
  Bump version for 2.2.0-rc3 release
  [modxcms#6247] Fix additional minify issues with CMP controllers in MODX_ASSETS_PATH
  Added default style for iconCls on Ext buttons Added default styles for close button on closable tabs
  Fixed date formatting bug in package getlist processor + 3 missing CSS properties in xtheme-modx
  Translated the changed phrase in namespace.inc.php to German
  [modxcms#6428] Fix improperly designated tooltip and UI for create namespace window
  Remove debug call
  Fix various regression issues with rename/delete files/directories in the Files tree
  Fix for date_timezone system setting
  Ensure hideFiles property works for the files tree
  Corrected key names of date_timezone settings in setting.inc.php in German translation
  Fix min_cachePath to respect MODX cache_path
  Ensure hideFiles property works for the files tree
  Corrected key names of date_timezone settings in setting.inc.php in German translation
  Fix min_cachePath to respect MODX cache_path
  [modxcms#6383] Add index.php to minify paths
  Prevent TVs tab from showing in Resources if the only TVs are of type "hidden"
  [modxcms#6413] Fix missing date_timezone setting description
  [modxcms#6297] Prevent invalid characters in property set names
  [modxcms#5997] Fix issue where components dirs were being created in assets with non-standard assets directory paths
  ...
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-setup bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
Revolution-2.2.0-rc3
Development

No branches or pull requests
2 participants
@splittingred @modxbot