Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

220-rc2 manager (still) won't load #6383

Closed
goldsky opened this issue Dec 17, 2011 · 9 comments
Closed

220-rc2 manager (still) won't load #6383

goldsky opened this issue Dec 17, 2011 · 9 comments
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.

Comments

@goldsky
Copy link
Contributor

goldsky commented Dec 17, 2011

goldsky created Redmine issue ID 6383

related with the previous bug (http://bugs.modx.com/issues/6063)

@opengeek
Copy link
Member

opengeek submitted:

The previous issue was resolved, and in addition, you no longer have to set the manager_js_document_root for min to work; it should automatically handle any virtual directory paths with things within the manager (or the document root).

In order to provide additional assistance, we will need details on your environment and specifically what the symptoms are.

@goldsky
Copy link
Contributor Author

goldsky commented Dec 17, 2011

goldsky submitted:

Revolution 2.2.0-rc2, traditional distro.
Tested on Firefox 8.0, Chrome 16.0.912.63 m, Opera 11.52, and Safari 5.1.2.
All the same.

no error_log, but here are the install logs, from D:\localhost\test-modx-2.2.0-rc2\core\cache

@opengeek
Copy link
Member

opengeek submitted:

I need the PHP errors, which may be logged in the Apache error_log, or if you can use your browsers developer tools to see why the requests are failing to min. Are you getting Bad Request responses or 500 Server errors from the calls to min?

Also, what is your $_SERVER['DOCUMENT_ROOT'] and how are you accessing your site? URLs, and physical paths if different from the document root.

@goldsky
Copy link
Contributor Author

goldsky commented Dec 18, 2011

goldsky submitted:

Alright, I almost there.

I found the culprit from my side.
The templates call requests without stated min/index.php explicitly.
They only determine min/?f=, or min/?g=.
That's why the CSS and JS won't be loaded.

I've make some changes to those templates, and seems they're starting to work.
I still can not find some other template files, that might be hidden in a dynamic call.
Please see this attachment.

@goldsky
Copy link
Contributor Author

goldsky commented Dec 19, 2011

goldsky submitted:

YES! Got them all!

The curse belongs to modmanagercontroller.class.php
Just search and replace these:

// src="'.$minDir.'?f='
src="'.$minDir.'index.php?f='

or

// 'min/?f='
'min/index.php?f='

see attachment.

@MarkH
Copy link

MarkH commented Dec 19, 2011

markh submitted:

There's a ht.access in that min dir - when you revert your class, and change that ht.access to .htaccess, does that solve the issue as well?

I think it would be interesting to see what the contents of the combined and minified files are - in your almost-there file it shows a doctype meaning it's returning HTML - possibly some PHP errors that need to be resolved?

@goldsky
Copy link
Contributor Author

goldsky commented Dec 19, 2011

goldsky submitted:

Just avoid .htaccess hack.
The script should independent from redirect, except FURL.
That only applies to Apache server, not to IIS.

The doctype didn't mean anything.
The real log was the complete HTML on that page.
There is no PHP error whatsoever, in apache's error log, or in modx's.

@opengeek
Copy link
Member

opengeek submitted:

This is actually a server configuration error. Most web servers that handle PHP files will have index.php load from any directory requests, like /min/. I will make these changes, but index.php should be configured to load in directories within MODX for proper operation; otherwise, requests to the root of your site might not be handled properly either.

@goldsky
Copy link
Contributor Author

goldsky commented Dec 22, 2011

goldsky submitted:

I'm not sure that this is a MODx's coding standard.
I even believe that http://bugs.modx.com/issues/6381 also came from the same cause.

I had a problem with TinyMCE's processors also because of this habit.

I just hope that this is not become MODx's 'validated' standard.

danyaPostfactum pushed a commit to danyaPostfactum/revolution that referenced this issue Mar 27, 2014
Merge branch 'release-2.2'

* release-2.2: (33 commits)
  Bump version for 2.2.0-rc3 release
  [modxcms#6247] Fix additional minify issues with CMP controllers in MODX_ASSETS_PATH
  Added default style for iconCls on Ext buttons Added default styles for close button on closable tabs
  Fixed date formatting bug in package getlist processor + 3 missing CSS properties in xtheme-modx
  Translated the changed phrase in namespace.inc.php to German
  [modxcms#6428] Fix improperly designated tooltip and UI for create namespace window
  Remove debug call
  Fix various regression issues with rename/delete files/directories in the Files tree
  Fix for date_timezone system setting
  Ensure hideFiles property works for the files tree
  Corrected key names of date_timezone settings in setting.inc.php in German translation
  Fix min_cachePath to respect MODX cache_path
  Ensure hideFiles property works for the files tree
  Corrected key names of date_timezone settings in setting.inc.php in German translation
  Fix min_cachePath to respect MODX cache_path
  [modxcms#6383] Add index.php to minify paths
  Prevent TVs tab from showing in Resources if the only TVs are of type "hidden"
  [modxcms#6413] Fix missing date_timezone setting description
  [modxcms#6297] Prevent invalid characters in property set names
  [modxcms#5997] Fix issue where components dirs were being created in assets with non-standard assets directory paths
  ...
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

No branches or pull requests

3 participants